Merge pull request 'B2025-047 PROMS crashes when opening a procedure as a Reviewer after a restore is performed and the ROFST Load Status completes.' (#617 ) from B2025-047 into Development

good for testing phase
B2025-047 PROMS crashes when opening a procedure as a Reviewer after a restore is performed and the ROFST Load Status completes.
2025-09-17 13:46:35 -04:00 · 2025-09-17 13:13:18 -04:00 · 2025-09-17 09:51:31 -04:00 · 2025-09-17 09:50:34 -04:00 · 2025-09-16 15:48:44 -04:00 · 2025-09-16 15:40:12 -04:00
7 changed files with 2 additions and 7 deletions
--- a/PROMS/Formats/fmtall/BVPS1all.xml
+++ b/PROMS/Formats/fmtall/BVPS1all.xml
--- a/PROMS/Formats/fmtall/BVPS2all.xml
+++ b/PROMS/Formats/fmtall/BVPS2all.xml
--- a/PROMS/Formats/fmtall/BVPSAOPall.xml
+++ b/PROMS/Formats/fmtall/BVPSAOPall.xml
--- a/PROMS/Formats/fmtall/BVPSAtchall.xml
+++ b/PROMS/Formats/fmtall/BVPSAtchall.xml
--- a/PROMS/Formats/fmtall/BVPSSAMGall.xml
+++ b/PROMS/Formats/fmtall/BVPSSAMGall.xml
--- a/Interface/PROMSFixes.Sql
+++ b/Interface/PROMSFixes.Sql
@@ -20588,11 +20588,6 @@ GO
 	GO


-
-	-- Delete All Existing Rofst Table Data
-	Delete From RofstHeader;
-
-
 /*
 ==========================================================================================================
 End: B2022-083: Support Conditional RO Values (v2.1)
--- a/PROMS/Volian.Controls.Library/DisplayRO.cs
+++ b/PROMS/Volian.Controls.Library/DisplayRO.cs
@@ -614,7 +614,7 @@ namespace Volian.Controls.Library
 					AddDummyGroup(db, tn);
 				}

-				_currRofstID = (int?)MyROFST.ROFstID;
+				_currRofstID = (IsRofstValid) ? (int?)_myROFST.ROFstID : null;
 				_currDocVersionID = null;

 				if(_docVersionInfo != null) _currDocVersionID = (int?)_docVersionInfo.VersionID;
@@ -789,7 +789,7 @@ namespace Volian.Controls.Library

 		private void AddDummyGroup(ROFSTLookup.rodbi rodbi, TreeNode tn)
 		{
-			if (MyROFSTLookup.HasChildren(ref rodbi))
+			if (IsRofstValid && MyROFSTLookup.HasChildren(ref rodbi))
 			{
 				TreeNode tmp = new TreeNode(DummyNodeText);
 				tn.Nodes.Add(tmp);
Author	SHA1	Message	Date
John Jenko	24c25ab26c	Merge pull request 'B2025-047 PROMS crashes when opening a procedure as a Reviewer after a restore is performed and the ROFST Load Status completes.' (#617 ) from B2025-047 into Development good for testing phase	2025-09-17 13:46:35 -04:00
mschill	9da91e460f	B2025-047 PROMS crashes when opening a procedure as a Reviewer after a restore is performed and the ROFST Load Status completes.	2025-09-17 13:13:18 -04:00
John Jenko	2634cf7de9	Merge pull request 'F2025-018 BVPS Added a new attachment section F2025-019 BVPS Removed format flag that uppercases setpoint units in HLS' (#616 ) from F2025-018-019_BVPS_2colAttSect_SetPtUnits into Development Format only changes. Good for Testing phase.	2025-09-17 09:51:31 -04:00
John Jenko	7417091f3f	F2025-018 BVPS Added a new attachment section F2025-019 BVPS Removed format flag that uppercases setpoint units in HLS	2025-09-17 09:50:34 -04:00
John Jenko	f9aad50f46	Merge pull request 'C2025-055 ROFST Load Status bar loading when shouldnt' (#615 ) from C2025-055 into Development good for testing phase	2025-09-16 15:48:44 -04:00
Matthew Schill	535cd5af2e	Merge branch 'Development' into C2025-055	2025-09-16 15:40:12 -04:00
mschill	4a8e469736	C2025-055 ROFST Load Status bar loading when shouldnt	2025-09-16 15:39:41 -04:00
John Jenko	7d89f711fe	Merge pull request 'C2021-058 Admin Tool Purge Change History/C2025-052 Admin Tool Index Maintenance' (#614 ) from C2021-058_C2025-052 into Development good for testing phase	2025-09-16 10:51:55 -04:00