Procedure-Pdf-Page-Count #1

Merged
jjenko merged 1 commits from Procedure-Pdf-Page-Count into master 2026-07-23 10:44:34 -04:00
Owner

Proc PDF page count

Proc PDF page count
plarsen self-assigned this 2026-07-23 10:32:30 -04:00
djankowski was assigned by plarsen 2026-07-23 10:32:30 -04:00
jjenko was assigned by plarsen 2026-07-23 10:32:30 -04:00
mschill was assigned by plarsen 2026-07-23 10:32:30 -04:00
plarsen added 1 commit 2026-07-23 10:32:31 -04:00
plarsen requested review from jjenko 2026-07-23 10:32:31 -04:00
plarsen requested review from mschill 2026-07-23 10:32:31 -04:00
mschill approved these changes 2026-07-23 10:41:18 -04:00
mschill left a comment
Owner

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.
@@ -0,0 +30,4 @@
using (var fbd = new FolderBrowserDialog())
{
fbd.Description = "Select the PDF folder";
//fbd.ShowHiddenFiles = true;
Owner

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.
@@ -0,0 +37,4 @@
{
pdffiles = Directory.GetFiles(fbd.SelectedPath,"*.pdf");
System.Windows.Forms.MessageBox.Show("Files found: " + pdffiles.Length.ToString(), "Message");
Owner

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.
@@ -0,0 +101,4 @@
}
catch (Exception ex)
{
System.Windows.Forms.MessageBox.Show("An Error has occured. Please try again. Error: " + ex.Message);
Owner

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.
@@ -0,0 +114,4 @@
ExcelApp.Visible = true;
}
//private void pageCountView_CellContentClick(object sender, DataGridViewCellEventArgs e)
Owner

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.
@@ -0,0 +121,4 @@
private void pageCountView_CellDoubleClick(object sender, DataGridViewCellEventArgs e)
{
DataGridViewCell cell = pageCountView.Rows[e.RowIndex].Cells[e.ColumnIndex];
//System.Windows.Forms.MessageBox.Show("Double Click Row Index: " + cell.Value.ToString());
Owner

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.

Not worried about it since stand alone app - but in general should remove commented out code and use string interpolation instead of concatenation. Just bringing it up as a "get in the habit thing" as working on the Technical Debt Upgrade & if we are not doing these things moving forward, we will essentially be undoing what we are doing with the Technical Debt upgrade.
jjenko approved these changes 2026-07-23 10:43:37 -04:00
jjenko left a comment
Owner

looks good

looks good
jjenko merged commit 5f6d2779d7 into master 2026-07-23 10:44:34 -04:00
Sign in to join this conversation.
No Reviewers
No labels
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/Applications#1