Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

B2026 053 find unlinked values of selected #795

Merged
mschill merged 28 commits from B2026-053-Find-Unlinked-Values-of-Selected into Development 2026-07-30 15:29:20 -04:00
Conversation 10 Commits 28 Files Changed 1
+1 -5
1 changed files with 1 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit bc9407f52f - Show all commits
PROMS/Volian.Controls.Library/DisplaySearch.cs
+1 -5
View File
7
 @@ -2179,13 +2179,9 @@ namespace Volian.Controls.Library
} }
private Dictionary<string, string> GetByWordSettings(string ss) private Dictionary<string, string> GetByWordSettings(string ss)
{ {
Dictionary<string, string> settings = new Dictionary<string, string>(); Dictionary<string, string> settings = new Dictionary<string, string>();
string byWordPrefix = string.Empty; if (Regex.IsMatch(ss, @"^[\d\.]")) // starts with a number or '.' decimal pt
string byWordSuffix = string.Empty;
if (Regex.IsMatch(ss, @"^[\d\.]")) // starts with a number or '.' decimal pt
{ {
mschill marked this conversation as resolved Outdated
mschill commented 2026-07-29 13:35:00 -04:00
Outdated
Review
Copy Link
Copy Source

Previous comments regarding Regexes still apply -- also it appears now we have 2 variables that we declared but did not use in string byWordPrefix & string byWordSuffix

Previous comments regarding Regexes still apply -- also it appears now we have 2 variables that we declared but did not use in string byWordPrefix & string byWordSuffix
plarsen commented 2026-07-29 13:54:28 -04:00
Outdated
Review
Copy Link
Copy Source

I removed the two unneeded variable declarations. I used what was previous used for the regex string. If you notice both tests are looking to see what the first character is and not the whole searchstring and from that it selects different regex strings. On account of this I am not sure char.IsNumeric will work because there are searchstrings that start with a number but are a mix of numbers and characters. Example 5% code: "if (Regex.IsMatch(ss, @"^[\d.]")) // starts with a number or '.' decimal pt"

I removed the two unneeded variable declarations. I used what was previous used for the regex string. If you notice both tests are looking to see what the first character is and not the whole searchstring and from that it selects different regex strings. On account of this I am not sure char.IsNumeric will work because there are searchstrings that start with a number but are a mix of numbers and characters. Example 5% code: "if (Regex.IsMatch(ss, @"^[\d\.]")) // starts with a number or '.' decimal pt"
settings.Add("byWordPrefix", @"[^0-9a-zA-Z.vbpi:\\-]"); settings.Add("byWordPrefix", @"[^0-9a-zA-Z.vbpi:\\-]");
} }
8