Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

B2026 053 find unlinked values of selected #795

Merged
mschill merged 28 commits from B2026-053-Find-Unlinked-Values-of-Selected into Development 2026-07-30 15:29:20 -04:00
Conversation 10 Commits 28 Files Changed 1
+9 -5
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 58a6cb9a24 - Show all commits
PROMS/Volian.Controls.Library/DisplaySearch.cs
+9 -5
View File
3
 @@ -2079,7 +2079,7 @@ namespace Volian.Controls.Library
if (cbxFndUnLnkROVals.Enabled && cbxFndUnLnkROVals.Checked) if (cbxFndUnLnkROVals.Enabled && cbxFndUnLnkROVals.Checked)
{ {
string ROSearchList2 = exactsearch(ROSearchList); // match exact string string ROSearchList2 = exactsearch(ROSearchList); // match exact string
// B2022-031 - added a cbxProcSectSrch to filter out procedure and section titles from global search results. // B2022-031 - added a exactsearch to filter out procedure and section titles from global search results.
SearchResults = ItemInfoList.GetListFromTextSearch(DVISearchList, TypeSearchList, ROSearchList2, cbxBooleanTxtSrch.Checked ? 2 : cbxCaseSensitive.Checked ? 1 : 0, cbxProcSectSrch.Checked ? 1 : 0, ItemSearchIncludeLinks.Nothing, includeRTFformat, includeSpecialChars, unitPrefix, string.Empty, string.Empty); SearchResults = ItemInfoList.GetListFromTextSearch(DVISearchList, TypeSearchList, ROSearchList2, cbxBooleanTxtSrch.Checked ? 2 : cbxCaseSensitive.Checked ? 1 : 0, cbxProcSectSrch.Checked ? 1 : 0, ItemSearchIncludeLinks.Nothing, includeRTFformat, includeSpecialChars, unitPrefix, string.Empty, string.Empty);
cmbResultsStyleIndex = 3; // display step text in results cmbResultsStyleIndex = 3; // display step text in results
mschill commented 2026-07-29 05:54:12 -04:00
Outdated
Review
Copy Link
Copy Source

lines 2092 - 2099 - the setting of ByWordPrefeix and ByWordSuffixL

Regexes are very hard on applications performance wise --- If just want to determine if a string ends in a Number, can't you use something like:

char.IsNumber(ROSearchList, ROSearchList.Length - 1);
char.IsLetter(ROSearchList, ROSearchList.Length - 1);
char.IsNumber(ROSearchList, 0);
char.IsLetter(ROSearchList, 0);

There are also functions like char.IsDigit if needed.

Obviously, you would need to 1st check that temp.Length > 0

Side question - if all we are doing is adding a regex prefix/suffix onto the checking code --- could we end up with stuff like 3.5 matching 3.52 since both end in a number and contain 3.5 ? -- You may be able to do something like pull back all the matches and then use LINQ to filter the list to ones that either end with the match or contain a space/bracket/parenthesis/punctuation after the match .

lines 2092 - 2099 - the setting of ByWordPrefeix and ByWordSuffixL Regexes are very hard on applications performance wise --- If just want to determine if a string ends in a Number, can't you use something like: char.IsNumber(ROSearchList, ROSearchList.Length - 1); char.IsLetter(ROSearchList, ROSearchList.Length - 1); char.IsNumber(ROSearchList, 0); char.IsLetter(ROSearchList, 0); There are also functions like char.IsDigit if needed. Obviously, you would need to 1st check that temp.Length > 0 Side question - if all we are doing is adding a regex prefix/suffix onto the checking code --- could we end up with stuff like 3.5 matching 3.52 since both end in a number and contain 3.5 ? -- You may be able to do something like pull back all the matches and then use LINQ to filter the list to ones that either end with the match or contain a space/bracket/parenthesis/punctuation after the match .
jjenko commented 2026-07-29 08:36:29 -04:00
Outdated
Review
Copy Link
Copy Source

Matt,
I don't know if this makes any difference, but the byWordPrex and byWordSuffix strings get passed to a SQL stored procedure.

That same code is used above this code block for doing a By Word text search. I was going to suggest that instead of copying the code, to make it it's own function and call it in the two places.

Matt, I don't know if this makes any difference, but the byWordPrex and byWordSuffix strings get passed to a SQL stored procedure. That same code is used above this code block for doing a By Word text search. I was going to suggest that instead of copying the code, to make it it's own function and call it in the two places.
mschill commented 2026-07-29 08:42:57 -04:00
Outdated
Review
Copy Link
Copy Source

Would agree - if it is repeated code / a repeated idea - better to make it it's own function. That being said, while regexes are necessary in some places, any place that it works where we can replace a call with function calls like char.IsNumeric, it will benefit performance,

Would agree - if it is repeated code / a repeated idea - better to make it it's own function. That being said, while regexes are necessary in some places, any place that it works where we can replace a call with function calls like char.IsNumeric, it will benefit performance,
} }
3
 @@ -2193,18 +2193,22 @@ namespace Volian.Controls.Library
private string exactsearch(string SearchString) // B2026-053 private string exactsearch(string SearchString) // B2026-053
jjenko marked this conversation as resolved Outdated
jjenko commented 2026-07-27 14:53:29 -04:00
Outdated
Review
Copy Link
Copy Source

by always adding a space before the search text, it will not find places where the unlinked RO Value is the first thing on the line. Ex. an Equipment List might have only the unlinked RO Value.

I noticed that the last two fields in the call to GetListFromTextSearch() are for a "by word" text search and passes in a Regx expression. Could that be used? - look for "if (cbxByWord.Checked)"

by always adding a space before the search text, it will not find places where the unlinked RO Value is the first thing on the line. Ex. an Equipment List might have only the unlinked RO Value. I noticed that the last two fields in the call to GetListFromTextSearch() are for a "by word" text search and passes in a Regx expression. Could that be used? - look for "if (cbxByWord.Checked)"
{ {
string ss = ""; //string ss = "";
StringBuilder ss = new StringBuilder();
int sl = SearchString.Length; int sl = SearchString.Length;
int LstIdxSp = SearchString.LastIndexOf(' '); int LstIdxSp = SearchString.LastIndexOf(' ');
if (sl == LstIdxSp + 1) // B2026-053 if ' ' the last char. if (sl == LstIdxSp + 1) // B2026-053 if ' ' the last char.
{ {
ss = ' ' + SearchString; //add a space prefix to make the search exact if the end of the search string is a space. ss.Append(' ');
mschill marked this conversation as resolved Outdated
mschill commented 2026-07-24 10:59:55 -04:00
Outdated
Review
Copy Link
Copy Source

What if multiple % signs? - like search for:
3% or 4% --- I believe the matches returned by the Regex object will give position of what is found.

What if multiple % signs? - like search for: 3% or 4% --- I believe the matches returned by the Regex object will give position of what is found.
ss.Append(SearchString); // B2026-053 add a space prefix to make the search exact if the end of the searchString is a space.
} }
else else
{ {
ss = ' ' + SearchString + ' '; // Exact match add spaces before and after search string. ss.Append(' ');
ss.Append(SearchString); // B2026-053 Exact match add spaces before and after searchString.
mschill marked this conversation as resolved Outdated
mschill commented 2026-07-24 11:02:50 -04:00
Outdated
Review
Copy Link
Copy Source

With working on tech debt project --- moving forward need to follow suggested code practices / suggestions by SonarLint --- if (isNumeric == true) should be
if (isNumeric)

With working on tech debt project --- moving forward need to follow suggested code practices / suggestions by SonarLint --- if (isNumeric == true) should be if (isNumeric)
ss.Append(' ');
} }
mschill marked this conversation as resolved Outdated
mschill commented 2026-07-24 11:03:48 -04:00
Outdated
Review
Copy Link
Copy Source

With working on technical debt - should avoid concatenating strings & use string interpolation instead.

With working on technical debt - should avoid concatenating strings & use string interpolation instead.
return ss; return ss.ToString();
} }
private void ClearResults() // B2021-103 if no results when RNO only, clear results list. (moved from btnSearch_Click) private void ClearResults() // B2021-103 if no results when RNO only, clear results list. (moved from btnSearch_Click)
mschill marked this conversation as resolved Outdated
mschill commented 2026-07-24 11:03:53 -04:00
Outdated
Review
Copy Link
Copy Source

With working on technical debt - should avoid concatenating strings & use string interpolation instead.

With working on technical debt - should avoid concatenating strings & use string interpolation instead.
3