Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

C2020-049-Add-the-ability-for-PROMS-to-remember-the-procedure-tabs-that-were-open-when-you-closed-PROMS-4 #420

Merged
mschill merged 3 commits from C2020-049-Add-the-ability-for-PROMS-to-remember-the-procedure-tabs-that-were-open-when-you-closed-PROMS-4 into Development 2024-10-07 11:51:37 -04:00
Conversation 5 Commits 3 Files Changed 1 +34 -2
plarsen commented 2024-10-04 14:43:45 -04:00
Owner
Copy Link

Added missing table DisplayTabTmp to PROMSFixes.sql

Added missing table DisplayTabTmp to PROMSFixes.sql
C2020-049-Add-the-ability-for-PROMS-to-remember-the-procedure-tabs-that-were-open-when-you-closed-PROMS.docx
174 KiB
plarsen self-assigned this 2024-10-04 14:43:45 -04:00
djankowski was assigned by plarsen 2024-10-04 14:43:45 -04:00
jjenko was assigned by plarsen 2024-10-04 14:43:45 -04:00
mschill was assigned by plarsen 2024-10-04 14:43:45 -04:00
plarsen added 1 commit 2024-10-04 14:43:46 -04:00
plarsen requested review from jjenko 2024-10-04 14:43:56 -04:00
djankowski requested review from mschill 2024-10-04 14:46:19 -04:00
mschill reviewed 2024-10-04 14:47:30 -04:00
PROMS/VEPROMS User Interface/PROMSFixes.Sql Outdated
@ -23798,7 +23798,7 @@ BEGIN TRY -- Try Block
--then remove the link from the copy
--if original item was not linked, update new items to not be linked
DECLARE @xconfig XML = (Select cast(config as xml) xconfig from Contents where ContentID = @ContentID);
IF ISNULL(@xconfig.exist('//Enhanced[1]'),0) = 0
mschill commented 2024-10-04 14:47:30 -04:00
Owner
Copy Link

this change needs to remain in / may need to resubmit with get latest.

this was a change based on what Paul Linn found with the Paste/Replace testing this morning.

this change needs to remain in / may need to resubmit with get latest. this was a change based on what Paul Linn found with the Paste/Replace testing this morning.
plarsen commented 2024-10-04 14:58:18 -04:00
Author
Owner
Copy Link

I did get latest, and the change was included.

I did get latest, and the change was included.
mschill commented 2024-10-04 15:08:57 -04:00
Owner
Copy Link

It is still not showing / line 23801 is showing as:
IF @xconfig.exist('//Enhanced[1]') = 0

instead of:

IF ISNULL(@xconfig.exist('//Enhanced[1]'),0) = 0

Let me know if you have any questions - I can do a screenshare to show what I am seeing.

It is still not showing / line 23801 is showing as: IF @xconfig.exist('//Enhanced[1]') = 0 instead of: IF ISNULL(@xconfig.exist('//Enhanced[1]'),0) = 0 Let me know if you have any questions - I can do a screenshare to show what I am seeing.
mschill marked this conversation as resolved
mschill requested changes 2024-10-04 14:49:26 -04:00
Dismissed
mschill left a comment
Owner
Copy Link

Looks good with the exception of the line 23801 change - which needs to remain in wrapped in the ISNULL.

Looks good with the exception of the line 23801 change - which needs to remain in wrapped in the ISNULL.
jjenko approved these changes 2024-10-04 14:49:29 -04:00
Dismissed
jjenko left a comment
Owner
Copy Link

Paul, can you remove the C2020-049 from the RevDescription?

Paul, can you remove the C2020-049 from the RevDescription?
👍 1
plarsen added 1 commit 2024-10-04 14:55:20 -04:00
jjenko approved these changes 2024-10-04 14:58:03 -04:00
jjenko left a comment
Owner
Copy Link

I'm good with the changes

I'm good with the changes
plarsen added 1 commit 2024-10-07 11:40:49 -04:00
mschill approved these changes 2024-10-07 11:50:56 -04:00
mschill left a comment
Owner
Copy Link

Looks good with the added change:

  • removed the csm number
  • fixed the removal of previous change
Looks good with the added change: - removed the csm number - fixed the removal of previous change
mschill merged commit 68639eadf0 into Development 2024-10-07 11:51:37 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
jjenko
mschill
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
djankowski jjenko lbutler mschill mvickers plarsen
No Assignees plarsen djankowski jjenko mschill
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Volian/SourceCode#420
No description provided.
Delete Branch "C2020-049-Add-the-ability-for-PROMS-to-remember-the-procedure-tabs-that-were-open-when-you-closed-PROMS-4"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?