B2026-064 – Updating ROs from Display ROs should not error

Merge pull request 'F2026_015 Moved the change bar position to the right one space to accommodate the wider Caution and Note boxes' (#786 ) from F2026-015_SouthTexas_ChgBars into Development
format only change. Ready for testing
2026-07-07 10:59:51 -04:00 · 2026-07-01 09:15:24 -04:00 · 2026-07-01 09:17:23 -04:00 · 2026-07-01 08:19:38 -04:00 · 2026-07-01 07:21:25 -04:00 · 2026-06-30 14:34:22 -04:00
5 changed files with 146 additions and 151 deletions
@@ -25052,7 +25052,7 @@ BEGIN TRY -- Try Block
 	DECLARE @RevDescription varchar(255)

 	set @RevDate = '06/29/2026 7:00 AM'
-	set @RevDescription = Update to Grid Deletion Audits'
+	set @RevDescription = 'Update to Grid Deletion Audits'

 	Select  cast(@RevDate as datetime) RevDate, @RevDescription  RevDescription
 	PRINT 'SQL Code Revision ' + @RevDate + ' - ' + @RevDescription
@@ -653,8 +653,6 @@ namespace Volian.Controls.Library
                        //do nothing - is still checked out
                    }
                    else if (changedDocVersion && !askedAboutchangedDocVersion)
-                    {
-                        Task.Run(() =>
                    {
                            if (MessageBox.Show($"There exists a newer ROFST for this RO database that was loaded for other sets.\r\n\r\nDo you want to update this set's ROs to be consistent/use the latest loaded ROFST?", "Load ROs", MessageBoxButtons.YesNo) == DialogResult.Yes)
                            {
@@ -678,7 +676,6 @@ namespace Volian.Controls.Library
                            {
                                askedAboutchangedDocVersion = true;
                            }
-                        });

                    }
                }
@@ -468,15 +468,18 @@ namespace Volian.Controls.Library
 					this.Refresh();
 					myFormatVersionList = FormatVersionList.GetFormatVersions();
 					cbxTranVersion.DisplayMember = "Title";
-					int lastLastFormatID = 0;
-					foreach (FormatVersion fv in myFormatVersionList)
-					{
-						if (fv.FormatID != lastLastFormatID)
+
+                    List<FormatVersion> fvlst = myFormatVersionList.GroupBy(x => x.FormatID).Select(group => new
+						FormatVersion(title: group.Max(x => x.Title),
+							formatID: group.Key,
+							versionID: group.Max(x => x.VersionID)
+						)).OrderBy(y => y.Title).ToList();
+
+                    foreach (FormatVersion fv in fvlst)
 					{
 						cbxTranVersion.Items.Add(fv);
-							lastLastFormatID = fv.FormatID;
-						}
 					}
+
 					cbxTranVersion.SelectedIndexChanged -= new EventHandler(cbxTranVersion_SelectedIndexChanged);
 					cbxTranVersion.SelectedIndexChanged += new EventHandler(cbxTranVersion_SelectedIndexChanged);
 					cbxTranFormat.SelectedIndexChanged -= new EventHandler(cbxTranFormat_SelectedIndexChanged);
@@ -556,14 +559,9 @@ namespace Volian.Controls.Library
 			string versionList = string.Empty;
 			string sep = string.Empty;
 			FormatVersion sfv = cbxTranVersion.SelectedItem as FormatVersion;
-			foreach (FormatVersion fv in myFormatVersionList)
-			{
-				if (fv.FormatID == sfv.FormatID)
-				{
-					versionList += sep + fv.VersionID;
-					sep = ",";
-				}
-			}
+
+			versionList = string.Join(",", myFormatVersionList.Where(x => x.FormatID == sfv?.FormatID).Select(y => y.VersionID));
+
 			cbxTranVersion.Tag = versionList;
 			cbxTranFormatFillIn(versionList);
 			if (dicExpandedFolderNodes.Count > 0)
Author	SHA1	Message	Date
mschill	ad33097d5e	B2026-064 – Updating ROs from Display ROs should not error	2026-07-07 10:59:51 -04:00
jjenko	8d7735735e	Merge pull request 'F2026_015 Moved the change bar position to the right one space to accommodate the wider Caution and Note boxes' (#786 ) from F2026-015_SouthTexas_ChgBars into Development format only change. Ready for testing	2026-07-01 09:15:24 -04:00
jjenko	25bbc46925	F2026_015 Moved the change bar position to the right one space to accommodate the wider Caution and Note boxes	2026-07-01 09:17:23 -04:00
jjenko	5a26b0ee35	Merge pull request 'B2026-054 - When performing a Transition search, the Formats dropdown list is repeating several times.' (#785 ) from B2026-054 into Development good for testing phase	2026-07-01 08:19:38 -04:00
mschill	09a397bed2	B2026-054 - When performing a Transition search, the Formats dropdown list is repeating several times.	2026-07-01 07:21:25 -04:00
jjenko	a33039bcae	Merge pull request 'F2026-014 South Texas EOP format – adjusted the Caution and Note box width. Also remove the extra space between bullets and multiple Caution/Note text' (#784 ) from F2026-014_SouthTexas_Caution_Box_Width into Development format only changes - ready for testing	2026-06-30 14:34:22 -04:00
jjenko	fd16a6b6c3	Merge pull request 'B2026-063 - Issue Deleting Steps with Grids' (#783 ) from B2026-063 into Development good for testing	2026-06-30 13:50:22 -04:00
mschill	cf19f764c7	Copy / Paste Error when updating Revision Comment	2026-06-30 13:49:37 -04:00