Merge pull request 'B2026-019 Attempt to prevent an Access Error by utilizing a different Refresh if a Procedure is Open' (#719) from B2026-019 into Development

good for testing phase

PROMS/VEPROMS User Interface/dlgApproveProcedure.cs

@@ -1337,24 +1337,37 @@ namespace VEPROMS
                     pi.ClearChangeBarOverrides();
 
 					//B2019-140 Change bars do not get refreshed when approval is run.
-					ProcedureInfo newproc = ItemInfo.ResetProcedure(pi.ItemID);
+					ProcedureInfo newproc;
 
-					//// Refresh the StepPanel for the current Procedure
+                    //// Refresh the StepPanel for the current Procedure
-					//// so change bars update
+                    //// so change bars update
-					//// on any open StepPanel
+                    //// on any open StepPanel
-					DisplayTabItem dti = MyFrmVEPROMS.GetTabContainingProcedure(pi.ItemID);
+
+                    //B2026-019 Attempt to prevent an Access Error by utilizing a different Refresh if a Procedure is Open
+                    DisplayTabItem dti = MyFrmVEPROMS.GetTabContainingProcedure(pi.ItemID);
 					if (dti != null)
 					{
 						if (!dti.MyStepTabPanel.MyStepPanel.ContainsFocus)
 							dti.MyStepTabPanel.MyStepPanel.Focus();
 
 						foreach (EditItem eitm in dti.MyStepTabPanel.MyStepPanel.Controls.OfType<EditItem>())
-							eitm.ChangeBar = eitm.MyItemInfo.HasChangeBar;
+                        {
-					}
+                            eitm.ChangeBar = eitm.MyItemInfo.HasChangeBar;
+                        }
 
-					//since in a separate form, need to update the tree view
+                        dti.MyStepTabPanel.MyStepTabRibbon.RefreshProcedure();
-					//so "Showing Change Bars" Content Menu Item is correct
+                        Application.DoEvents();
-					MyFrmVEPROMS.RefreshProcedureNode(newproc);
+                        newproc = ProcedureInfo.Get(pi.ItemID);
+
+                    }
+					else
+					{
+                        newproc = ItemInfo.ResetProcedure(pi.ItemID);
+                    }
+
+						//since in a separate form, need to update the tree view
+						//so "Showing Change Bars" Content Menu Item is correct
+						MyFrmVEPROMS.RefreshProcedureNode(newproc);
 				}
 				else
 					UpdateProcedureConfig(pi, ap.RevNumber, ap.RevDate, myDTS, selectedSlave);

PROMS/VEPROMS User Interface/frmVEPROMS.cs

@@ -626,22 +626,31 @@ namespace VEPROMS
 					itm.UserID = Volian.Base.Library.VlnSettings.UserID;
 					itm.Save();
 
-					//B2019-140 Change bars do not get refreshed when approval is run.
+                    //B2019-140 Change bars do not get refreshed when approval is run.
-					// Reset a Procedure and sub items in the cache
+                    // Reset a Procedure and sub items in the cache
-					ProcedureInfo newproc = ItemInfo.ResetProcedure(pi.ItemID);
 
-					//// Refresh the StepPanel for the current Procedure
+                    //// Refresh the StepPanel for the current Procedure
-					//// so change bars update
+                    //// so change bars update
-					//// on any open StepPanel
+                    //// on any open StepPanel
-					DisplayTabItem dti = GetTabContainingProcedure(pi.ItemID);
+					
-                    if (dti != null)
+                    //B2026-019 Attempt to prevent an Access Error by utilizing a different Refresh if a Procedure is Open
-                    {
+                    DisplayTabItem dti = GetTabContainingProcedure(pi.ItemID);
-                        if (!dti.MyStepTabPanel.MyStepPanel.ContainsFocus)
+					if (dti != null)
-                            dti.MyStepTabPanel.MyStepPanel.Focus();
+					{
+						if (!dti.MyStepTabPanel.MyStepPanel.ContainsFocus)
+							dti.MyStepTabPanel.MyStepPanel.Focus();
 
 						foreach (EditItem eitm in dti.MyStepTabPanel.MyStepPanel.Controls.OfType<EditItem>())
+						{
 							eitm.ChangeBar = eitm.MyItemInfo.HasChangeBar;
+						}
+
+						dti.MyStepTabPanel.MyStepTabRibbon.RefreshProcedure();
 					}
+					else
+					{
+                        _ = ItemInfo.ResetProcedure(pi.ItemID);
+                    }
 				}
 			}
 		}

PROMS/VEPROMS.CSLA.Library/Extension/ItemExt.cs

@@ -3839,9 +3839,17 @@ namespace VEPROMS.CSLA.Library
 			_SupInfos = null;
 		}
 
-		//B2019-140 Change bars do not get refreshed when approval is run.
+        //B2019-140 Change bars do not get refreshed when approval is run.
-		// Reset a Procedure and sub items in the cache
+        // Reset a Procedure and sub items in the cache
-		public static ProcedureInfo ResetProcedure(int procID)
+        // **********************
+        // Be carefull calling this when the Procedure is Open
+        // When the Procedure is Open - use StepTabRibbon.RefreshProcedure(); instead
+        // When a Procedure is open and you try to refresh it,
+        // events can fire behind the scenes - causing data to try to be accessed while you are trying to refresh it
+        // When This occurs, it will cause a 
+        // "ThreadException ... Collection was modified; enumeration operation may not execute.”
+        // **********************
+        public static ProcedureInfo ResetProcedure(int procID)
 		{
 			// The following lines reload the procedure info cache
 			ProcedureInfo newproc = ProcedureInfo.Get(procID, true);