B2026-064 – Updating ROs from Display ROs should not error

format only change.  Ready for testing

PROMS/Volian.Controls.Library/DisplayRO.cs

@@ -653,8 +653,6 @@ namespace Volian.Controls.Library
                         //do nothing - is still checked out
                     }
                     else if (changedDocVersion && !askedAboutchangedDocVersion)
-                    {
-                        Task.Run(() =>
                     {
                             if (MessageBox.Show($"There exists a newer ROFST for this RO database that was loaded for other sets.\r\n\r\nDo you want to update this set's ROs to be consistent/use the latest loaded ROFST?", "Load ROs", MessageBoxButtons.YesNo) == DialogResult.Yes)
                             {
@@ -678,7 +676,6 @@ namespace Volian.Controls.Library
                             {
                                 askedAboutchangedDocVersion = true;
                             }
-                        });
 
                     }
                 }

PROMS/Volian.Controls.Library/DisplaySearch.cs

@@ -468,15 +468,18 @@ namespace Volian.Controls.Library
 					this.Refresh();
 					myFormatVersionList = FormatVersionList.GetFormatVersions();
 					cbxTranVersion.DisplayMember = "Title";
-					int lastLastFormatID = 0;
-					foreach (FormatVersion fv in myFormatVersionList)
-					{
-						if (fv.FormatID != lastLastFormatID)
+
+                    List<FormatVersion> fvlst = myFormatVersionList.GroupBy(x => x.FormatID).Select(group => new
+						FormatVersion(title: group.Max(x => x.Title),
+							formatID: group.Key,
+							versionID: group.Max(x => x.VersionID)
+						)).OrderBy(y => y.Title).ToList();
+
+                    foreach (FormatVersion fv in fvlst)
 					{
 						cbxTranVersion.Items.Add(fv);
-							lastLastFormatID = fv.FormatID;
-						}
 					}
+
 					cbxTranVersion.SelectedIndexChanged -= new EventHandler(cbxTranVersion_SelectedIndexChanged);
 					cbxTranVersion.SelectedIndexChanged += new EventHandler(cbxTranVersion_SelectedIndexChanged);
 					cbxTranFormat.SelectedIndexChanged -= new EventHandler(cbxTranFormat_SelectedIndexChanged);
@@ -556,14 +559,9 @@ namespace Volian.Controls.Library
 			string versionList = string.Empty;
 			string sep = string.Empty;
 			FormatVersion sfv = cbxTranVersion.SelectedItem as FormatVersion;
-			foreach (FormatVersion fv in myFormatVersionList)
-			{
-				if (fv.FormatID == sfv.FormatID)
-				{
-					versionList += sep + fv.VersionID;
-					sep = ",";
-				}
-			}
+
+			versionList = string.Join(",", myFormatVersionList.Where(x => x.FormatID == sfv?.FormatID).Select(y => y.VersionID));
+
 			cbxTranVersion.Tag = versionList;
 			cbxTranFormatFillIn(versionList);
 			if (dicExpandedFolderNodes.Count > 0)