B2024-041 - Update PromsFixes for the RevDate and RevDescriptions

PROMS/VEPROMS User Interface/PROMSFixes.Sql

@@ -22230,11 +22230,9 @@ Go
 
 
 
-	/*
+
-==========================================================================================================
+
- Begin: C2024-004 | B2024-041: KL - Update Copy Replace functionality, (remove ''copy of'')
+
-==========================================================================================================
-*/
 
 
 IF EXISTS (SELECT * FROM dbo.sysobjects WHERE id = OBJECT_ID(N'[ReplaceItemAndChildren]') AND OBJECTPROPERTY(id,N'IsProcedure') = 1)
@@ -23247,11 +23245,9 @@ BEGIN CATCH -- Catch Block
 END CATCH
 Go
 
-/*
+
-==========================================================================================================
+
- End: C2024-004: KL - Update Copy Replace functionality, (remove ''copy of'')
+
-==========================================================================================================
-*/
 
 
 
@@ -23289,8 +23285,8 @@ BEGIN TRY -- Try Block
 	DECLARE @RevDate varchar(255)
 	DECLARE @RevDescription varchar(255)
 
-	set @RevDate = '07/16/2024 4:19 AM'
+	set @RevDate = '07/16/2024 3:37 PM'
-	set @RevDescription = 'B2024-041: Bug fix for copy/replace functionality on procedures and steps'
+	set @RevDescription = 'B2024-041: Updates to allow for proper replace vs paste above or below'
 
 	Select  cast(@RevDate as datetime) RevDate, @RevDescription  RevDescription
 	PRINT 'SQL Code Revision ' + @RevDate + ' - ' + @RevDescription

PROMS/Volian.Controls.Library/DisplaySearch.cs

@@ -346,11 +346,10 @@ namespace Volian.Controls.Library
 								ch = (ROFSTLookup.rochild)cmboTreeROs.SelectedNode.Tag;
 								chld = ch.children;
 								// build a list of ROs to search
-								// B2022-118: remove the ending comma otherwise query will fail
+								return _MyRODbID.ToString() + ":" + GetROsToSearch(chld);
-								string strRtnStr = _MyRODbID.ToString() + ":" + GetROsToSearch(chld);
+								//return _MyRODbID.ToString() + ":" + ch.roid + "0000," + GetROsToSearch(chld);
-								if (strRtnStr.EndsWith(","))
+								//if (strRtnStr.EndsWith(","))
-									strRtnStr = strRtnStr.Substring(0, strRtnStr.Length - 1);
+								//	strRtnStr = strRtnStr.Substring(0, strRtnStr.Length - 1);
-								return strRtnStr;
 							}
 						}
 					}
@@ -1940,13 +1939,6 @@ namespace Volian.Controls.Library
 		private string GetROsToSearch(ROFSTLookup.rochild[] chld)
 		{
 			string rtnstr = string.Empty;
-			// B2022-118: If the ro has child nodes in tree view but they aren't loaded, load them
-			if ((chld == null || chld.Length <= 0) && (cmboTreeROs.SelectedNode.Nodes != null || cmboTreeROs.SelectedNode.Nodes.Count >= 1))
-			{
-				ROFSTLookup.rochild ro = (ROFSTLookup.rochild)cmboTreeROs.SelectedNode.Tag;
-				MyROFSTLookup.LoadChildren(ref ro);
-				chld = ro.children;
-			}
 
 			// B2022-026 RO Memory Reduction code - check children length
 			if (chld == null || chld.Length <= 0) // get a single ROID
@@ -1964,17 +1956,7 @@ namespace Volian.Controls.Library
 					if (roc.children != null && roc.children.Length > 0)
 						rtnstr += GetROsToSearch(roc.children);
 					else
-					{
+						rtnstr += ROFSTLookup.FormatRoidKey(roc.roid, false);
-						// B2022-118: If the ro has child nodes in tree view but they aren't loaded, load them
-						ROFSTLookup.rochild rot = roc;
-						MyROFSTLookup.LoadChildren(ref rot);
-						chld = rot.children;
-
-						if (rot.children != null && rot.children.Length > 0)
-							rtnstr += GetROsToSearch(rot.children);
-						else
-							rtnstr += string.Format("{0},", ROFSTLookup.FormatRoidKey(roc.roid, false));
-					}
 				}
 			}
 

PROMS/Volian.Controls.Library/DisplayTabControl.cs

@@ -669,7 +669,7 @@ namespace Volian.Controls.Library
 			ItemInfo proc = myItemInfo.MyProcedure; // Find procedure Item
 			string key = "Item - " + proc.ItemID.ToString();
 
-			if (_MyDisplayTabItems.ContainsKey(key) && pasteType != ItemInfo.EAddpingPart.Replace) // If procedure page open use it unless replace
+			if (_MyDisplayTabItems.ContainsKey(key)) // If procedure page open use it
 			{
 				DisplayTabItem pg = _MyDisplayTabItems[key];
 				if (pg.MyStepTabPanel.MyStepPanel._LookupEditItems.ContainsKey(myItemInfo.ItemID) &&
@@ -708,11 +708,6 @@ namespace Volian.Controls.Library
 					return true;
 				}
 			}
-			else if (_MyDisplayTabItems.ContainsKey(key) && pasteType == ItemInfo.EAddpingPart.Replace)
-			{
-				CloseTabItem(_MyDisplayTabItems["Item - " + myItemInfo.ItemID.ToString()]); //Grab itemID and set to close open tab.
-				return false; //B2017-179 PasteReplace will return null if was aborted
-			}
 			return false;
 		}
 

PROMS/Volian.Controls.Library/EditItem.cs

@@ -1825,16 +1825,8 @@ namespace Volian.Controls.Library
 			EditItem newFocus = null;
 			EditItem nextEditItem = MyNextEditItem;
 			EditItem prevEditItem = MyPreviousEditItem;
-			EditItem parentEditItem = null; // ActiveParent;
+			if (MyStepPanel?.SelectedEditItem?.ActiveParent == null) return null; //Was causing an error when active parent was null and the replaced proc was opened in the editor.
-			try
+			EditItem parentEditItem = ActiveParent;
-			{
-				parentEditItem = ActiveParent ?? MyStepPanel?.SelectedEditItem?.ActiveParent;
-			}
-			catch (NullReferenceException)
-			{
-				// KL 7/11/2024 - Handle the case where ActiveParent throws a Null Reference Exception
-				parentEditItem = MyStepPanel?.SelectedEditItem?.ActiveParent; 
-			}
 
 			StepConfig savOrigPasteConfig = MyItemInfo.MyConfig as StepConfig;
 			int TopMostYBefore = TopMostEditItem.Top;