diff --git a/PROMS/Formats/fmtall/SUMSAMall.xml b/PROMS/Formats/fmtall/SUMSAMall.xml index 4b073fb5..0cdcb992 100644 Binary files a/PROMS/Formats/fmtall/SUMSAMall.xml and b/PROMS/Formats/fmtall/SUMSAMall.xml differ diff --git a/PROMS/Formats/fmtall/SUMall.xml b/PROMS/Formats/fmtall/SUMall.xml index 3873bf8b..0cfbc902 100644 Binary files a/PROMS/Formats/fmtall/SUMall.xml and b/PROMS/Formats/fmtall/SUMall.xml differ diff --git a/PROMS/VEPROMS User Interface/PROMSFixes.Sql b/PROMS/VEPROMS User Interface/PROMSFixes.Sql index 5209a3a7..ab6f422e 100644 --- a/PROMS/VEPROMS User Interface/PROMSFixes.Sql +++ b/PROMS/VEPROMS User Interface/PROMSFixes.Sql @@ -5547,6 +5547,12 @@ ELSE PRINT 'Function: ve_GetItemDerivedApplicability Error on Creation' GO ------- + +-- ============================================= +-- Author: Matthew Schill +-- Modify date: 07/14/2026 +-- Description: Reworked ve_GetParentItem for Performance improvement +-- ============================================= /****** Object: UserDefinedFunction [dbo].[vefn_GetParentItem] Script Date: 03/28/2012 17:58:48 ******/ IF EXISTS (SELECT * FROM dbo.sysobjects WHERE id = OBJECT_ID(N'[ve_GetParentItem]') AND OBJECTPROPERTY(id,N'IsScalarFunction') = 1) DROP FUNCTION [ve_GetParentItem]; @@ -5555,35 +5561,46 @@ GO Volian Enterprises - Proprietary Information - DO NOT COPY OR DISTRIBUTE Copyright 2012 - Volian Enterprises, Inc. All rights reserved. *****************************************************************************/ -CREATE FUNCTION [dbo].[ve_GetParentItem] (@ItemID int) RETURNS int +CREATE OR ALTER FUNCTION [dbo].[ve_GetParentItem] (@ItemID int) RETURNS int WITH EXECUTE AS OWNER AS BEGIN DECLARE @ParentID int; -WITH Itemz([ItemID],[IsFound]) as +WITH Itemz([ItemID]) as ( -select ii.itemid,0 from items ii where ii.itemid = @ItemID +select ii.itemid from items ii WITH (NOLOCK) where ii.itemid = @ItemID union all -select ii.previousid,0 from items ii +select ii.previousid from items ii WITH (NOLOCK) join itemz zz on ii.itemid = zz.itemid where ii.previousid is not null -and zz.isfound = 0 -union all -select ii.itemid,1 -from parts pp -join itemz zz on pp.itemid = zz.itemid -join items ii on ii.contentid = pp.contentid ) -select top 1 @ParentID = itemid from itemz -where isfound = 1 OPTION (MAXRECURSION 10000) +select top 1 @ParentID = ii.itemid +from itemz +inner join parts pp WITH (NOLOCK) on pp.itemid = itemz.itemid +inner join items ii WITH (NOLOCK) on ii.contentid = pp.contentid +OPTION (MAXRECURSION 10000) + RETURN @ParentID END + GO IF (@@Error = 0) PRINT 'ScalerFunction [vefn_GetParentItem] Succeeded' ELSE PRINT 'ScalerFunction [vefn_GetParentItem] Error on Creation' go +IF EXISTS (SELECT * FROM dbo.sysIndexes WHERE name like 'IX_PartsItemID') + DROP INDEX [IX_PartsItemID] ON [dbo].[tblParts]; +GO + +CREATE NONCLUSTERED INDEX IX_PartsItemID +ON [dbo].[tblParts] ([ItemID] ASC) +INCLUDE([ContentID],[DeleteStatus],[FromType]) WITH (PAD_INDEX = OFF, STATISTICS_NORECOMPUTE = OFF, SORT_IN_TEMPDB = OFF, DROP_EXISTING = OFF, ONLINE = OFF, ALLOW_ROW_LOCKS = ON, ALLOW_PAGE_LOCKS = ON) ON [PRIMARY] +GO + +PRINT 'Added IX_PartsItemID Index. Speeds up Getting Parent Items' +GO + /****** Object: UserDefinedFunction [dbo].[vefn_CanTransitionBeCreated] Script Date: 10/14/2012 02:03:30 ******/ IF EXISTS (SELECT * FROM dbo.sysobjects WHERE id = OBJECT_ID(N'[vefn_CanTransitionBeCreated]') AND OBJECTPROPERTY(id,N'IsScalarFunction') = 1) DROP FUNCTION [vefn_CanTransitionBeCreated]; @@ -25051,8 +25068,8 @@ BEGIN TRY -- Try Block DECLARE @RevDate varchar(255) DECLARE @RevDescription varchar(255) - set @RevDate = '06/29/2026 7:00 AM' - set @RevDescription = 'Update to Grid Deletion Audits' + set @RevDate = '07/16/2026 8:30 AM' + set @RevDescription = 'Reworked ve_GetParentItem for Performance improvement' Select cast(@RevDate as datetime) RevDate, @RevDescription RevDescription PRINT 'SQL Code Revision ' + @RevDate + ' - ' + @RevDescription diff --git a/PROMS/VEPROMS.CSLA.Library/Extension/ROFSTExt.cs b/PROMS/VEPROMS.CSLA.Library/Extension/ROFSTExt.cs index 0098d346..f2e4ffc2 100644 --- a/PROMS/VEPROMS.CSLA.Library/Extension/ROFSTExt.cs +++ b/PROMS/VEPROMS.CSLA.Library/Extension/ROFSTExt.cs @@ -326,7 +326,9 @@ namespace VEPROMS.CSLA.Library // all of the calls aways set the flags to not update the RO values public static ROFst UpdateRoFst(RODbInfo rdi, DocVersion docver, ROFstInfo origROFst, ROFstInfoProgressBarRefresh myProgressBarRefresh) { - if (myProgressBarRefresh != null) myProgressBarRefresh(0, 100, "Starting Update"); + ROWorkingDraftAsk.ClearWorkingDrafts(); + + if (myProgressBarRefresh != null) myProgressBarRefresh(0, 100, "Starting Update"); int origFSTid = origROFst.ROFstID; diff --git a/PROMS/VEPROMS.CSLA.Library/Session/ROWorkingDraftAsk.cs b/PROMS/VEPROMS.CSLA.Library/Session/ROWorkingDraftAsk.cs new file mode 100644 index 00000000..f78280ac --- /dev/null +++ b/PROMS/VEPROMS.CSLA.Library/Session/ROWorkingDraftAsk.cs @@ -0,0 +1,18 @@ + +using System.Collections.Generic; + +namespace VEPROMS.CSLA.Library +{ + public static class ROWorkingDraftAsk + { + [System.Diagnostics.CodeAnalysis.SuppressMessage("Style", "IDE0044:Add readonly modifier", Justification = "Keeping Collections Not ReadOnly")] + private static List WorkingDrafts = new List(); + + public static void AddWorkingDrafts(int wd) => WorkingDrafts.Add(wd); + + public static void ClearWorkingDrafts() => WorkingDrafts.Clear(); + + public static bool ContainsWorkingDraft(int wd) => WorkingDrafts.Contains(wd); + + } +} diff --git a/PROMS/VEPROMS.CSLA.Library/VEPROMS.CSLA.Library.csproj b/PROMS/VEPROMS.CSLA.Library/VEPROMS.CSLA.Library.csproj index 1b9a09b2..db431669 100644 --- a/PROMS/VEPROMS.CSLA.Library/VEPROMS.CSLA.Library.csproj +++ b/PROMS/VEPROMS.CSLA.Library/VEPROMS.CSLA.Library.csproj @@ -396,6 +396,7 @@ + diff --git a/PROMS/Volian.Controls.Library/DisplayRO.cs b/PROMS/Volian.Controls.Library/DisplayRO.cs index 7c271a05..86ff26cb 100644 --- a/PROMS/Volian.Controls.Library/DisplayRO.cs +++ b/PROMS/Volian.Controls.Library/DisplayRO.cs @@ -652,7 +652,7 @@ namespace Volian.Controls.Library { //do nothing - is still checked out } - else if (changedDocVersion && !askedAboutchangedDocVersion) + else if (changedDocVersion && !askedAboutchangedDocVersion && !ROWorkingDraftAsk.ContainsWorkingDraft(_docVersionInfo.VersionID)) { if (MessageBox.Show($"There exists a newer ROFST for this RO database that was loaded for other sets.\r\n\r\nDo you want to update this set's ROs to be consistent/use the latest loaded ROFST?", "Load ROs", MessageBoxButtons.YesNo) == DialogResult.Yes) { @@ -671,10 +671,13 @@ namespace Volian.Controls.Library updatedROs = true; askedAboutchangedDocVersion = false; + ROWorkingDraftAsk.ClearWorkingDrafts(); } else { askedAboutchangedDocVersion = true; + if (!ROWorkingDraftAsk.ContainsWorkingDraft(_docVersionInfo.VersionID)) + ROWorkingDraftAsk.AddWorkingDrafts(_docVersionInfo.VersionID); } }