Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

B2026-019 Attempt to prevent an Access Error by utilizing a different Refresh if a Procedure is Open

Browse Source
This commit is contained in:
Matthew Schill
2026-03-02 14:12:26 -05:00
parent c42596811e
commit a7b5ee33e2
2 changed files with 20 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
PROMS/VEPROMS User Interface/frmVEPROMS.cs
View File

@@ -628,16 +628,16 @@ namespace VEPROMS
//B2019-140 Change bars do not get refreshed when approval is run. //B2019-140 Change bars do not get refreshed when approval is run.
// Reset a Procedure and sub items in the cache // Reset a Procedure and sub items in the cache
ProcedureInfo newproc = ItemInfo.ResetProcedure(pi.ItemID);
//// Refresh the StepPanel for the current Procedure //// Refresh the StepPanel for the current Procedure
//// so change bars update //// so change bars update
//// on any open StepPanel //// on any open StepPanel
//B2026-019 Attempt to prevent an Access Error by utilizing a different Refresh if a Procedure is Open //B2026-019 Attempt to prevent an Access Error by utilizing a different Refresh if a Procedure is Open
DisplayTabItem dti = GetTabContainingProcedure(pi.ItemID); DisplayTabItem dti = GetTabContainingProcedure(pi.ItemID);
if (dti != null) if (dti != null)
{ {
_ = ItemInfo.ResetProcedure(pi.ItemID, true);
if (!dti.MyStepTabPanel.MyStepPanel.ContainsFocus) if (!dti.MyStepTabPanel.MyStepPanel.ContainsFocus)
dti.MyStepTabPanel.MyStepPanel.Focus(); dti.MyStepTabPanel.MyStepPanel.Focus();
@@ -646,13 +646,7 @@ namespace VEPROMS
{ {
eitm.ChangeBar = eitm.MyItemInfo.HasChangeBar; eitm.ChangeBar = eitm.MyItemInfo.HasChangeBar;
} }
dti.MyStepTabPanel.MyStepTabRibbon.RefreshProcedure();
} }
else
{
_ = ItemInfo.ResetProcedure(pi.ItemID);
}
} }
} }
} }

39
PROMS/VEPROMS.CSLA.Library/Extension/ItemExt.cs
View File

@@ -3849,7 +3849,7 @@ namespace VEPROMS.CSLA.Library
// When This occurs, it will cause a // When This occurs, it will cause a
// "ThreadException ... Collection was modified; enumeration operation may not execute.” // "ThreadException ... Collection was modified; enumeration operation may not execute.”
// ********************** // **********************
public static ProcedureInfo ResetProcedure(int procID, bool resetindisplaytab = false) public static ProcedureInfo ResetProcedure(int procID)
{ {
// The following lines reload the procedure info cache // The following lines reload the procedure info cache
ProcedureInfo newproc = ProcedureInfo.Get(procID, true); ProcedureInfo newproc = ProcedureInfo.Get(procID, true);
@@ -3867,30 +3867,27 @@ namespace VEPROMS.CSLA.Library
ItemInfo newprocitem = Get(procID, true); ItemInfo newprocitem = Get(procID, true);
newprocitem.RefreshConfig(); newprocitem.RefreshConfig();
if (!resetindisplaytab) //Reload all the child/sub items
{
//Reload all the child/sub items
#pragma warning disable S2971 // LINQ expressions should be simplified - need initial ToList to force enumeration #pragma warning disable S2971 // LINQ expressions should be simplified - need initial ToList to force enumeration
//otherwise will get a "Collection was modified; enumeration operation may not execute" error //otherwise will get a "Collection was modified; enumeration operation may not execute" error
List<int> itemIDs = _CacheByPrimaryKey.Values.ToList().SelectMany(y => y).Where(t => t?.ActiveParent != null && (t.ActiveParent is ItemInfo) && t.MyProcedure.ItemID == procID).Select(x => (x.ActiveParent as ItemInfo).ItemID).Distinct().ToList(); List<int> itemIDs = _CacheByPrimaryKey.SelectMany(kvp => kvp.Value).ToList().Where(t => t?.ActiveParent != null && (t.ActiveParent is ItemInfo) && t.MyProcedure.ItemID == procID).Select(x => (x.ActiveParent as ItemInfo).ItemID).Distinct().ToList();
#pragma warning restore S2971 // LINQ expressions should be simplified #pragma warning restore S2971 // LINQ expressions should be simplified
for (int index = 0; index < itemIDs.Count; index++) for (int index = 0; index < itemIDs.Count; index++)
{ {
ResetParts(itemIDs[index]); ResetParts(itemIDs[index]);
}
//reset the procedure config for all items attached to current procedure
#pragma warning disable S2971 // LINQ expressions should be simplified - need initial ToList to force enumeration
//otherwise will get a "Collection was modified; enumeration operation may not execute" error
List<ItemInfo> pconfigrefresh_items = _CacheByPrimaryKey.Values.ToList().SelectMany(y => y).Where(t => t?.MyProcedure?.ItemID == procID).Distinct().ToList();
#pragma warning restore S2971 // LINQ expressions should be simplified
for (int index = 0; index < pconfigrefresh_items.Count; index++)
{
pconfigrefresh_items[index].MyProcedure = newproc;
}
} }
//reset the procedure config for all items attached to current procedure
#pragma warning disable S2971 // LINQ expressions should be simplified - need initial ToList to force enumeration
//otherwise will get a "Collection was modified; enumeration operation may not execute" error
List<ItemInfo> pconfigrefresh_items = _CacheByPrimaryKey.SelectMany(kvp => kvp.Value).ToList().Where(t => t?.MyProcedure?.ItemID == procID).Distinct().ToList();
#pragma warning restore S2971 // LINQ expressions should be simplified
for (int index = 0; index < pconfigrefresh_items.Count; index++)
{
pconfigrefresh_items[index].MyProcedure = newproc;
}
//return the changed procedure info //return the changed procedure info
return newproc; return newproc;
} }