Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

B2020-125: View of Consistency check report displaying error message and crashing

Browse Source
This commit is contained in:
Kathy Ruffing 2020-09-22 16:21:02 +00:00
parent c762960ddd
commit 59cb56ca88
2 changed files with 21 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
PROMS/VEPROMS.CSLA.Library/Config/ROFSTLookup.cs
View File

@ -470,7 +470,17 @@ namespace VEPROMS.CSLA.Library
rochild roc = GetRoChild12(ROID);
if (roc.value == null)
roc = GetRoChild(ROID);
sb.Append(roc.title.Replace(roc.appid,"").Replace(roc.value,"").Trim());
// B2020-125: View of Consistency check report displaying error message and crashing. And also in 'else' check for null
if (roc.ID == -1)
sb.Append("Could not find RO data");
else
{
string tmp = roc.title;
if (tmp == null) tmp = "";
if (roc.appid != null) tmp = tmp.Replace(roc.appid, "");
if (roc.value != null) tmp = tmp.Replace(roc.value, "");
sb.Append(tmp.Trim());
}
do
{
string parent = ROID.Substring(0, 4) + string.Format("{0:X8}", roc.ParentID);

13
PROMS/VEPROMS.CSLA.Library/Extension/RevisionInfoExt.cs
View File

@ -83,10 +83,17 @@ namespace VEPROMS.CSLA.Library
foreach (ROCheck roc in MyDifferences.ROConsistency.MyROChecks)
{
ROFSTLookup.rochild rocc = lu.GetRoChild12(roc.ROID);
if(rocc.type == 1)
sb.Append(string.Format(" {0} - Old Value: {1} - New Value: {2}\r\n", lu.GetROTitle(roc.ROID), roc.OldROValue, roc.ROValue));
if (rocc.ID == -1) // B2020-125: View of Consistency check report displaying error message and crashing.
{
sb.Append(string.Format(" {0}\r\n", lu.GetROTitle(roc.ROID)));
}
else
sb.Append(string.Format(" {0} - Value has changed.\r\n", lu.GetROTitle(roc.ROID)));
{
if (rocc.type == 1)
sb.Append(string.Format(" {0} - Old Value: {1} - New Value: {2}\r\n", lu.GetROTitle(roc.ROID), roc.OldROValue, roc.ROValue));
else
sb.Append(string.Format(" {0} - Value has changed.\r\n", lu.GetROTitle(roc.ROID)));
}
}
}
//jcb