Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

We missed a spot when fixing the bug B2016-081. When importing a transiition it was converting an internal transition to text. This has been fixed.

Browse Source 
B2018-002 Updated code that tracks and displays Transition Refresh Statistics
Added Statistic tracking for invalid transitions converted to text
This commit is contained in:
Rich
2018-01-24 14:44:46 +00:00
parent 8818376ab9
commit 58c23de1ea
2 changed files with 46 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
PROMS/VEPROMS User Interface/dlgExportImport.cs
View File

@@ -2776,7 +2776,9 @@ namespace VEPROMS
if (TransitionInfo.Get(tt.TransitionID).MyItemToID.ActiveSection != null)
{
SectionConfig sc = TransitionInfo.Get(tt.TransitionID).MyItemToID.ActiveSection.MyConfig as SectionConfig;
forceConvertToText = (sc.SubSection_Edit == "N");
// Bug fix B2016-081 also check if transition is to a step element
// This was found when fixing B2018-002 but it actually applies to B2016-081
forceConvertToText = (sc.SubSection_Edit == "N" && TransitionInfo.Get(tt.TransitionID).MyItemToID.IsStep);
}
_DidProcessTransitions |= cc.FixTransitionText(TransitionInfo.Get(tt.TransitionID), forceConvertToText); // B2017-076 FixTransitionText will tell us if transitions were processed/changed
// B2017=003 make sure any grid changes are saved.
@@ -2820,13 +2822,13 @@ namespace VEPROMS
cc.Text = cc.Text.Replace(lookfor, replacewith);
if (cc.MyGrid != null && cc.MyGrid.Data != "")
cc.MyGrid.Data = cc.MyGrid.Data.Replace(lookfor, replacewith);
if (TransitionInfo.Get(tt.TransitionID).MyItemToID.ActiveSection != null)
{
SectionConfig sc = TransitionInfo.Get(tt.TransitionID).MyItemToID.ActiveSection.MyConfig as SectionConfig;
forceConvertToText = (sc.SubSection_Edit == "N");
}
// B2016-176, B2016197 - external transitions should be convert to text
// B2016-176, B2016-197 - external transitions should be converted to text
forceConvertToText = true;
//if (TransitionInfo.Get(tt.TransitionID).MyItemToID.ActiveSection != null)
//{
// SectionConfig sc = TransitionInfo.Get(tt.TransitionID).MyItemToID.ActiveSection.MyConfig as SectionConfig;
// forceConvertToText = (sc.SubSection_Edit == "N");
//}
//if (!forceConvertToText) //check to see if external with internal format
//{
// TransitionInfo tran = TransitionInfo.Get(transitionid);