Volian/SourceCode
8
0
Fork 0
Code Issues Pull Requests 1 Projects Releases Wiki Activity

Improved performance of the SQL Stored procedures related to DeleteItemAndChildren.

Browse Source 
Added output so that status can be seen as a procedure is deleted.
This commit is contained in:
Rich 2015-08-12 22:14:44 +00:00
parent c3f58a6df7
commit 312b0e4e2d
3 changed files with 101 additions and 54 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

124
PROMS/DataLoader/PROMSFixes.Sql
View File

@ -3551,32 +3551,19 @@ RETURNS @Children TABLE
WITH EXECUTE AS OWNER WITH EXECUTE AS OWNER
AS AS
BEGIN BEGIN
with Itemz([Level], [Ordinal], [ItemID], [PreviousID], [FromType], [ContentID], [DTS], [UserID], [LastChanged],[pContentID], [pDTS],[pUserID],[pLastChanged]) as ( DECLARE @ChildList AS TABLE
Select 0 [Level], 0 [Ordinal], [ItemID], [PreviousID],0 [FromType],[ContentID],[DTS],[UserID],[LastChanged] (
,0 [pContentID],[DTS] [pDTS], [UserID] [pUserID], [LastChanged] [pLastChanged] ItemID INT PRIMARY KEY,
FROM [Items] ContentID INT,
where [ItemID]=@ItemID Level INT
Union All )
-- Children INSERT INTO @ChildList SELECT * FROM vefn_ChildItemz(@ItemID)
select [Level] + 1,0, I.[ItemID], I.[PreviousID], P.[FromType],I.[ContentID],I.[DTS],I.[UserID],I.[LastChanged]
,P.[ContentID] [pContentID],P.[DTS] [pDTS],P.[UserID] [pUserID],P.[LastChanged] [pLastChanged]
from Itemz Z
join Parts P on P.ContentID = Z.ContentID
join Items I on I.ItemID = P.ItemID
-- Siblings
Union All
select [Level] ,Z.[Ordinal] +1, I.[ItemID], I.[PreviousID], [FromType],I.[ContentID],I.[DTS],I.[UserID],I.[LastChanged]
,null,null,null,null
from Itemz Z
join Items I on I.PreviousID = Z.ItemID
where Z.[Level] > 0
)
insert into @Children insert into @Children
select ItemID [FromItemID], case when TT.ToID in(select ItemID from Itemz) then TT.ToID else TT.RangeID end [ToID] select ItemID [FromItemID], case when TT.ToID in(select ItemID from @ChildList) then TT.ToID else TT.RangeID end [ToID]
from Transitions TT from Transitions TT
join Items II on II.ContentID=TT.FromID join Items II on II.ContentID=TT.FromID
where (ToID in(select ItemID from Itemz where Level > 0) OR RangeID in(select ItemID from Itemz where Level > 0)) where (ToID in(select ItemID from @ChildList where Level > 0) OR RangeID in(select ItemID from @ChildList where Level > 0))
AND FromID not in(Select ContentID from ItemZ) AND FromID not in(Select ContentID from @ChildList)
OPTION (MAXRECURSION 10000) OPTION (MAXRECURSION 10000)
RETURN RETURN
END END
@ -3612,32 +3599,19 @@ RETURNS @Children TABLE
WITH EXECUTE AS OWNER WITH EXECUTE AS OWNER
AS AS
BEGIN BEGIN
with Itemz([Level], [Ordinal], [ItemID], [PreviousID], [FromType], [ContentID], [DTS], [UserID], [LastChanged],[pContentID], [pDTS],[pUserID],[pLastChanged]) as ( DECLARE @ChildList AS TABLE
Select 0 [Level], 0 [Ordinal], [ItemID], [PreviousID],0 [FromType],[ContentID],[DTS],[UserID],[LastChanged] (
,0 [pContentID],[DTS] [pDTS], [UserID] [pUserID], [LastChanged] [pLastChanged] ItemID INT PRIMARY KEY,
FROM [Items] ContentID INT,
where [ItemID]=@ItemID Level INT
Union All )
-- Children INSERT INTO @ChildList SELECT * FROM vefn_ChildItemz(@ItemID)
select [Level] + 1,0, I.[ItemID], I.[PreviousID], P.[FromType],I.[ContentID],I.[DTS],I.[UserID],I.[LastChanged]
,P.[ContentID] [pContentID],P.[DTS] [pDTS],P.[UserID] [pUserID],P.[LastChanged] [pLastChanged]
from Itemz Z
join Parts P on P.ContentID = Z.ContentID
join Items I on I.ItemID = P.ItemID
-- Siblings
Union All
select [Level] ,Z.[Ordinal] +1, I.[ItemID], I.[PreviousID], [FromType],I.[ContentID],I.[DTS],I.[UserID],I.[LastChanged]
,null,null,null,null
from Itemz Z
join Items I on I.PreviousID = Z.ItemID
where Z.[Level] > 0
)
insert into @Children insert into @Children
select ItemID [FromItemID], TT.[TransitionID], TT.[FromID], TT.[ToID], TT.[RangeID], TT.[Config] select ItemID [FromItemID], TT.[TransitionID], TT.[FromID], TT.[ToID], TT.[RangeID], TT.[Config]
from Transitions TT from Transitions TT
join Items II on II.ContentID=TT.FromID join Items II on II.ContentID=TT.FromID
where (ToID in(select ItemID from Itemz) OR RangeID in(select ItemID from Itemz)) where (ToID in(select ItemID from @ChildList) OR RangeID in(select ItemID from @ChildList))
AND FromID not in(Select ContentID from ItemZ) AND FromID not in(Select ContentID from @ChildList)
OPTION (MAXRECURSION 10000) OPTION (MAXRECURSION 10000)
RETURN RETURN
END END
@ -3647,6 +3621,56 @@ IF (@@Error = 0) PRINT 'TableFunction Creation: vefn_FindExternalTransitions Suc
ELSE PRINT 'TableFunction Creation: vefn_FindExternalTransitions Error on Creation' ELSE PRINT 'TableFunction Creation: vefn_FindExternalTransitions Error on Creation'
GO GO
/****** Object: StoredProcedure [vefn_ChildItemz] ******/
IF EXISTS (SELECT * FROM dbo.sysobjects WHERE id = OBJECT_ID(N'[vefn_ChildItemz]') AND OBJECTPROPERTY(id,N'IsTableFunction') = 1)
DROP FUNCTION [vefn_ChildItemz];
GO
/*
Select * from vefn_ChildItemz(185)
*/
/*****************************************************************************
Volian Enterprises - Proprietary Information - DO NOT COPY OR DISTRIBUTE
Copyright 2015 - Volian Enterprises, Inc. All rights reserved.
*****************************************************************************/
CREATE FUNCTION [dbo].[vefn_ChildItemz](@ItemID int)
RETURNS @Children TABLE
(
ItemID int PRIMARY KEY,
ContentID int,
Level int
)
WITH EXECUTE AS OWNER
AS
BEGIN
with Itemz([Level], [ItemID], [ContentID]) as (
Select 0 [Level], [ItemID], [ContentID]
FROM [Items]
where [ItemID]=@ItemID
Union All
-- Children
select [Level] + 1, I.[ItemID], I.[ContentID]
from Itemz Z
join Parts P on P.ContentID = Z.ContentID
join Items I on I.ItemID = P.ItemID
-- Siblings
Union All
select [Level] , I.[ItemID], I.[ContentID]
from Itemz Z
join Items I on I.PreviousID = Z.ItemID
where Z.[Level] > 0
)
insert into @Children select ItemID, ContentID, Level from Itemz
OPTION (MAXRECURSION 10000)
RETURN
END
GO
-- Display the status of Proc creation
IF (@@Error = 0) PRINT 'TableFunction Creation: vefn_ChildItemz Succeeded'
ELSE PRINT 'TableFunction Creation: vefn_ChildItemz Error on Creation'
GO
/****** Object: StoredProcedure [vefn_FindInternalTransitions] ******/ /****** Object: StoredProcedure [vefn_FindInternalTransitions] ******/
IF EXISTS (SELECT * FROM dbo.sysobjects WHERE id = OBJECT_ID(N'[vefn_FindInternalTransitions]') AND OBJECTPROPERTY(id,N'IsTableFunction') = 1) IF EXISTS (SELECT * FROM dbo.sysobjects WHERE id = OBJECT_ID(N'[vefn_FindInternalTransitions]') AND OBJECTPROPERTY(id,N'IsTableFunction') = 1)
DROP FUNCTION [vefn_FindInternalTransitions]; DROP FUNCTION [vefn_FindInternalTransitions];
@ -8930,12 +8954,9 @@ BEGIN TRY -- Try Block
SET NOCOUNT ON SET NOCOUNT ON
SELECT @ContentID = ContentID, @PreviousItemID = PreviousID FROM Items WHERE ItemID = @ItemID SELECT @ContentID = ContentID, @PreviousItemID = PreviousID FROM Items WHERE ItemID = @ItemID
SELECT @NextItemID = ItemID FROM Items WHERE PreviousID = @ItemID SELECT @NextItemID = ItemID FROM Items WHERE PreviousID = @ItemID
SET @Path = [dbo].[ve_GetShortPath](@ItemID)
SELECT @ExternalCount = count(*) FROM vefn_FindExternalTransitions(@ItemID) where rangeid = toid or toid = @ItemID SELECT @ExternalCount = count(*) FROM vefn_FindExternalTransitions(@ItemID) where rangeid = toid or toid = @ItemID
SELECT @ExternalChildCount = count(*) FROM vefn_FindExternalChildTransitions(@ItemID)
SELECT @ItemType = Type FROM Contents Where ContentID = @ContentID
SET @Path = [dbo].[ve_GetShortPath](@ItemID)
-- Check to see if External Transitions point to the current item
IF @ExternalCount > 0 AND @NextItemID is null IF @ExternalCount > 0 AND @NextItemID is null
BEGIN BEGIN
RAISERROR ('###Cannot Delete Item###Step %d has External Transitions and has no next step - (%s)',16,1,@ItemID,@Path) RAISERROR ('###Cannot Delete Item###Step %d has External Transitions and has no next step - (%s)',16,1,@ItemID,@Path)
@ -8948,6 +8969,9 @@ BEGIN TRY -- Try Block
RETURN RETURN
END END
SELECT @ExternalChildCount = count(*) FROM vefn_FindExternalChildTransitions(@ItemID)
SELECT @ItemType = Type FROM Contents Where ContentID = @ContentID
-- Check to see if External Transitions point to the current item
IF @ExternalChildCount > 0 IF @ExternalChildCount > 0
BEGIN BEGIN
RAISERROR ('###Cannot Delete Item###Step %d has External Transitions to it''s children - (%s)',16,1,@ItemID,@Path) RAISERROR ('###Cannot Delete Item###Step %d has External Transitions to it''s children - (%s)',16,1,@ItemID,@Path)
@ -10995,4 +11019,4 @@ END CATCH
IF (@@Error = 0) PRINT 'Procedure Creation: addROImage Succeeded' IF (@@Error = 0) PRINT 'Procedure Creation: addROImage Succeeded'
ELSE PRINT 'Procedure Creation: addROImage Error on Creation' ELSE PRINT 'Procedure Creation: addROImage Error on Creation'
GO GO
PRINT '20150722 Fixed AddROImage for WCN' PRINT '20150808 Improved performance for delete procedure'

2
PROMS/VEPROMS User Interface/frmVEPROMS.Designer.cs generated
View File

@ -548,7 +548,7 @@ namespace VEPROMS
this.bottomProgBar.MenuVisibility = DevComponents.DotNetBar.eMenuVisibility.VisibleAlways; this.bottomProgBar.MenuVisibility = DevComponents.DotNetBar.eMenuVisibility.VisibleAlways;
this.bottomProgBar.Name = "bottomProgBar"; this.bottomProgBar.Name = "bottomProgBar";
this.bottomProgBar.RecentlyUsed = false; this.bottomProgBar.RecentlyUsed = false;
this.bottomProgBar.Width = 150; this.bottomProgBar.Width = 250;
// //
// labelItem20 // labelItem20
// //

29
PROMS/VEPROMS User Interface/frmVEPROMS.cs
View File

@ -297,14 +297,36 @@ namespace VEPROMS
displayApplicability.ApplicabilityViewModeChanged += new DisplayApplicability.DisplayApplicabilityEvent(displayApplicability_ApplicabilityViewModeChanged); displayApplicability.ApplicabilityViewModeChanged += new DisplayApplicability.DisplayApplicabilityEvent(displayApplicability_ApplicabilityViewModeChanged);
tv.ExportImportProcedureSets += new vlnTreeViewEvent(tv_ExportImportProcedureSets); tv.ExportImportProcedureSets += new vlnTreeViewEvent(tv_ExportImportProcedureSets);
tv.PrintTransitionReport += new vlnTreeViewEvent(tv_PrintTransitionReport); tv.PrintTransitionReport += new vlnTreeViewEvent(tv_PrintTransitionReport);
tv.ProcessingComplete += tv_ProcessingComplete;
tv.Processing += tv_Processing;
}
private bool _SkipRefresh = false;
public bool SkipRefresh
{
get { return _SkipRefresh; }
set { _SkipRefresh = value; }
}
void tv_Processing(object sender, vlnTreeStatusEventArgs args)
{
SkipRefresh = args.MyStatus;
if (args.MyStatus)
bottomProgBar.ColorTable = eProgressBarItemColor.Paused;
else
bottomProgBar.ColorTable = eProgressBarItemColor.Normal;
bottomProgBar.Text = args.MyMessage;
bottomProgBar.TextVisible = true;
Application.DoEvents();
}
void tv_ProcessingComplete(object sender, vlnTreeTimeEventArgs args)
{
bottomProgBar.Text = string.Format("{0} seconds - {1}", args.MyTimeSpan.TotalSeconds, args.MyMessage);
Application.DoEvents();
} }
void bottomProgBar_ValueChanged(object sender, EventArgs e) void bottomProgBar_ValueChanged(object sender, EventArgs e)
{ {
if (bottomProgBar.Value < 10 && bottomProgBar.ColorTable != eProgressBarItemColor.Normal) if (bottomProgBar.Value < 10 && bottomProgBar.ColorTable != eProgressBarItemColor.Normal)
bottomProgBar.ColorTable = eProgressBarItemColor.Normal; bottomProgBar.ColorTable = eProgressBarItemColor.Normal;
} }
string tv_GetChangeId(object sender, vlnTreeItemInfoEventArgs args) string tv_GetChangeId(object sender, vlnTreeItemInfoEventArgs args)
{ {
tc.HandleChangeId(args.MyItemInfo, null); tc.HandleChangeId(args.MyItemInfo, null);
@ -947,6 +969,7 @@ namespace VEPROMS
} }
private void RefreshChanged(Object obj) private void RefreshChanged(Object obj)
{ {
if (SkipRefresh) return;
MySemaphore.WaitOne(); MySemaphore.WaitOne();
try try
{ {
@ -1071,7 +1094,7 @@ namespace VEPROMS
System.Threading.AutoResetEvent autoEvent = new System.Threading.AutoResetEvent(false); System.Threading.AutoResetEvent autoEvent = new System.Threading.AutoResetEvent(false);
//System.Threading.TimerCallback timerDelegate = new System.Threading.TimerCallback(MySessionInfo.PingSession); //System.Threading.TimerCallback timerDelegate = new System.Threading.TimerCallback(MySessionInfo.PingSession);
//System.Diagnostics.Process xyzzy = System.Diagnostics.Process.GetCurrentProcess(); //System.Diagnostics.Process xyzzy = System.Diagnostics.Process.GetCurrentProcess();
if(!System.Diagnostics.Debugger.IsAttached) if(!System.Diagnostics.Debugger.IsAttached)// running in Production Mode (Not in the debugger)
{ {
System.Threading.TimerCallback timerDelegate = new System.Threading.TimerCallback(this.PingSession); System.Threading.TimerCallback timerDelegate = new System.Threading.TimerCallback(this.PingSession);
MyActivityTimer = new System.Threading.Timer(timerDelegate, autoEvent, 10000, 10000); MyActivityTimer = new System.Threading.Timer(timerDelegate, autoEvent, 10000, 10000);